-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a MockAzureClient
which can simulate azure failures
#1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammadhamzasajjad
force-pushed
the
azure_storage_mock_client
branch
from
February 15, 2024 13:41
b50e086
to
ebc9af9
Compare
poodlewars
reviewed
Feb 15, 2024
IvoDD
reviewed
Feb 15, 2024
muhammadhamzasajjad
force-pushed
the
azure_storage_mock_client
branch
from
February 15, 2024 17:55
5677a5d
to
ab07c4a
Compare
poodlewars
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please squash the commits in to one before merging
IvoDD
approved these changes
Feb 16, 2024
5 tasks
muhammadhamzasajjad
added a commit
that referenced
this pull request
Mar 8, 2024
Similar to #1331. The mock client will then be used to test exception normalization. Wrap up common things like `StorageOperation` and `StorageFailure` into `storage_mock_client.hpp`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #1281.
MockAzureClient
instead of theRealAzureClient
MockAzureClient
is created, one can simulate failures by passing the appropriate symbol nameMockAzureClient
works properly forread
,write
,update
,delete
andlist
functions.To do: Test exceptions thrown by
MockAzureClient
. This will be done in the next PR where we normalize Azure exception.Checklist
Checklist for code changes...