Add penultimate key #1355
Merged
Add penultimate key #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdealtry
force-pushed
the
add_penultimate_key
branch
from
d658563
to
a5b9101
Compare
alexowens90
approved these changes
Feb 22, 2024
| @@ -20,7 +20,6 @@ struct ReadOptions { | |||
| std::optional<bool> set_tz_; | |||
| std::optional<bool> optimise_string_memory_; | |||
| std::optional<bool> batch_throw_on_error_; | |||
| std::optional<bool> read_previous_on_failure_; | |||
There was a problem hiding this comment.
@poodlewars has a PR out that removes this as well, just to be aware for whoever's merging second
willdealtry
force-pushed
the
add_penultimate_key
branch
5 times, most recently
from
a4a5192
to
2093a05
Compare
willdealtry
force-pushed
the
add_penultimate_key
branch
from
0cf7fa6
to
19e0c0b
Compare
|
I ran tests that reliably created ref key errors when run against a replicated AWS bucket, due to out of order replication. With the change from this those errors vanished, so it has solved the problem. |
5 tasks
poodlewars
added a commit
that referenced
this pull request
May 15, 2024
) #### What does this implement or fix? We should only write the version ref key once when we write with `prune_previous_versions=True`. Currently we are writing it twice - once after we write the tombstone all and once when we write the new version. This means that there is a period of time where the symbol is unreadable. This was fixed a while ago with PR #1104 but regressed with PR #1355.
poodlewars
added a commit
that referenced
this pull request
May 15, 2024
) #### What does this implement or fix? We should only write the version ref key once when we write with `prune_previous_versions=True`. Currently we are writing it twice - once after we write the tombstone all and once when we write the new version. This means that there is a period of time where the symbol is unreadable. This was fixed a while ago with PR #1104 but regressed with PR #1355.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the last undeleted key to the version ref key so that the penultimate index can be read even when the most recent version key has not yet been replicated due to AWS out-of-order replication