Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely disable Pandas consolidation #1561

Merged
merged 3 commits into from
May 10, 2024

Conversation

vasil-pashov
Copy link
Collaborator

@vasil-pashov vasil-pashov commented May 9, 2024

Reference Issues/PRs

Closes: #1226

What does this implement or fix?

  • Remove the environment variable which was used to enable the consolidation phase
  • Make our custom block manager to cast blocks for empty columns to float64. To be removed after empty types become enabled.

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

* Remove the environment variable which was used to enable the
  consolidation phase
* Make our custom block manager to cast blocks for empty columns to
  float64. To be removed after empty types become enabled.
@vasil-pashov vasil-pashov marked this pull request as ready for review May 10, 2024 11:57
@vasil-pashov vasil-pashov merged commit 89fc8bb into master May 10, 2024
114 checks passed
@vasil-pashov vasil-pashov deleted the remove-pandas-consolidation branch May 10, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check empty-type handling when Pandas DataFrame consolidation is disabled
2 participants