dev: Add simple pre-commit setup
#445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Changes originates from black as invoked by:
pre-commit run --all-files
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
poodlewars
approved these changes
May 31, 2023
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Alex Seaton <alex.seaton@man.com>
qc00
reviewed
Jun 1, 2023
| times.shape[0], s | ||
| ) | ||
| "Inconsistent size of column values. times.shape[0]={} must match cv.shape[0] for all column values." | ||
| " actual={}".format(times.shape[0], s) |
There was a problem hiding this comment.
It is not clear if the .format would extend to strings on a separate line, would have preferred another level of brackets
There was a problem hiding this comment.
I have opened #448 to make it clearer.
This was referenced Jun 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #146.
Follow-up of #431.
What does this implement/fix? Explain your changes.
This proposes setting up pre-commit hook using the
pre-commitpython project.For now, only hooks for
blackandflake8have been introduced to prevent failures of the CI.Later, we can add other ones, such as the one for
clang-formater(see #356).Any other comments?
The code base needs to be adapted to pass the checks (see the
TODOinsetup.cfg).