Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Aggregation tests] Replace non_zero_numeric_type_strategies with numeric_type_strategies #968

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[Aggregation tests] Replace non_zero_numeric_type_strategies with numeric_type_strategies #968

merged 1 commit into from
Nov 28, 2023

Conversation

Hind-M
Copy link
Collaborator

@Hind-M Hind-M commented Oct 17, 2023

Reference Issues/PRs

What does this implement or fix?

We don't need non_zero_numeric_type_strategies for aggregation tests.

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@Hind-M
Copy link
Collaborator Author

Hind-M commented Nov 21, 2023

@alexowens90 This PR is ready for review :)

@Hind-M Hind-M merged commit 7a19241 into master Nov 28, 2023
131 checks passed
@Hind-M Hind-M deleted the agg_tests branch November 28, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexowens90 alexowens90 alexowens90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hind-M @alexowens90