Turn EVM.Configuration into a behaviour #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
masonforest
approved these changes
Sep 26, 2018
What? ===== We turn `EVM.Configuration` into a Behaviour instead of a protocol. Why? ===== Behaviours and Protocols are two ways to implement polymorphism in Elixir. When we want a module to behave the same way as other modules, we want it to satisfy a behaviour (e.g. `GenServer`). When we want to create a somewhat generic set of operations on different types, we use protocols (e.g. `Enumerable` working on lists, ranges, etc). Since the `EVM.Configuration` lands on the first camp, we should use a `Behaviour` for it. This has the side-effect of cleaning up some dialyzer errors that made no sense previously, such as an `Atom` not having the `EVM.Configuration` protocol implemented. Co-authored-by: Matthew Sumner <matt.m.sumner@gmail.com>
germsvel
force-pushed
the
gv-mms-behaviours-not-protocols
branch
from
718e87f
to
520a374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We turn
EVM.Configurationinto a Behaviour instead of a protocol.Why?
Behaviours and Protocols are two ways to implement polymorphism in
Elixir. When we want a module to behave the same way as other modules,
we want it to satisfy a behaviour (e.g.
GenServer). When we want tocreate a somewhat generic set of operations on different types, we use
protocols (e.g.
Enumerableworking on lists, ranges, etc).Since the
EVM.Configurationlands on the first camp, we should use aBehaviourfor it. This has the side-effect of cleaning up somedialyzer errors that made no sense previously, such as an
Atomnothaving the
EVM.Configurationprotocol implemented.