Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for graceful error propagation #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olessavluk
Copy link

@olessavluk olessavluk commented Apr 26, 2022

Hello!

Currently, if an error is thrown during dispatch - it breaks future store notifications. This PR should fix that, to match the default dispatch behaviour.

Steps to reproduce:

  1. Place intentional error in reducer
  2. Dispatch action that crashes in the reducer
  3. Dispatch other actions and you will see that listeners do not get notified of state changes. Compared with "plain" redux where listeners updated

Let me know if the issue & this solution is clear to you

@pdesantis
Copy link

@olessavluk thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants