Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thor: add support for store/loadregisters on VirtualizedCpuDescriptors #123

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

Matt8898
Copy link
Contributor

No description provided.

Copy link
Member

@avdgrinten avdgrinten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, some comments.

hel/include/hel.h Outdated Show resolved Hide resolved
kernel/thor/generic/virtualization.hpp Outdated Show resolved Hide resolved
kernel/thor/generic/hel.cpp Outdated Show resolved Hide resolved
kernel/thor/generic/hel.cpp Outdated Show resolved Hide resolved
kernel/thor/generic/hel.cpp Outdated Show resolved Hide resolved
@Matt8898 Matt8898 force-pushed the master branch 2 times, most recently from 211fb98 to f54d637 Compare February 18, 2020 21:56
Copy link
Member

@avdgrinten avdgrinten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chnages look good; I'm only waiting for the naming change.

kernel/thor/arch/x86/vmx.hpp Outdated Show resolved Hide resolved
@avdgrinten
Copy link
Member

LGTM now.

@avdgrinten avdgrinten merged commit a4ab4ef into managarm:master Feb 19, 2020
64 pushed a commit to 64/managarm that referenced this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants