Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lfs64 additions, hsearch family of functions and icmp6 define #1063

Merged
merged 5 commits into from
May 27, 2024

Conversation

Qwinci
Copy link
Contributor

@Qwinci Qwinci commented May 15, 2024

Add more lfs64 aliases, implement hsearch family of functions (using internal functions hsearch_r/hdestroy_r/hsearch_r for posix hsearch/hdestroy/hsearch and glibc's hsearch_r/hdestroy_r/hsearch_r).

Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance, LGTM bar one comment.

options/internal/generic/search.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Geertiebear
Copy link
Member

Tests please 😭

@qookei qookei merged commit f1b7b83 into managarm:master May 27, 2024
18 of 34 checks passed
@Qwinci Qwinci deleted the lfs64-additions branch May 28, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants