-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: use libsmarter #719
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the changes in cxxabi.cpp needed? libsmarter should not call these operators (for example, they do not exist in thor).
libsmarter's make_shared at least seems to call |
Ah, okay. |
Why do we need this? The PR does not immediately add a usecase for libsmarter so I'm curious what you want to use it for. |
IIRC I wanted to use it for refcounting stuff in ld.so so that we don't e.g leak memory when we destroy threads. This PR needs a bit of updating as per my last comment, though |
Alright, but then at leas the use-case is clear, thanks. |
See also managarm/libsmarter#4.