Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: use libsmarter #719

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

internal: use libsmarter #719

wants to merge 1 commit into from

Conversation

64
Copy link
Member

@64 64 commented Aug 5, 2022 •
edited

@64 64 marked this pull request as ready for review August 5, 2022 18:25
no92
no92 approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

avdgrinten
avdgrinten reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@avdgrinten avdgrinten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the changes in cxxabi.cpp needed? libsmarter should not call these operators (for example, they do not exist in thor).

@64
Copy link
Member Author

64 commented Aug 10, 2022

libsmarter's make_shared at least seems to call operator new.

@64
Copy link
Member Author

64 commented Aug 10, 2022

Ah, okay. allocate_shared should do the same thing as make_shared but take an explicit allocator. We can just use that, then.

@Geertiebear
Copy link
Member

Why do we need this? The PR does not immediately add a usecase for libsmarter so I'm curious what you want to use it for.

@64
Copy link
Member Author

64 commented Nov 23, 2022

IIRC I wanted to use it for refcounting stuff in ld.so so that we don't e.g leak memory when we destroy threads. This PR needs a bit of updating as per my last comment, though

@Geertiebear
Copy link
Member

Alright, but then at leas the use-case is clear, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdgrinten avdgrinten avdgrinten left review comments

@no92 no92 no92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@64 @Geertiebear @no92 @avdgrinten