-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 7.4 support #397
Merged
Merged
Add PHP 7.4 support #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging on local branch so we can look at the errors |
Okay 👍 By the way, Blackfire is now compatible with PHP 7.4 (tweet from 6 days https://twitter.com/blackfireio/status/1208063286354358272), so maybe we won't have any errors about Blackfire with PHP 7.4 anymore. |
nervo
pushed a commit
that referenced
this pull request
Dec 26, 2019
* php 7.4: role apt * php 7.4: role opcache_dashboard * php 7.4: role php * php 7.4: role phpmyadmin * php 7.4: role phppgadmin * php 7.4: role phpredisadmin * php 7.4: role skeleton * php 7.4: forgot php fpm_pools configs Co-authored-by: Lod <46480794+greedybro@users.noreply.github.com>
greedybro
added a commit
that referenced
this pull request
Jan 6, 2020
* Add PHP 7.4 support (#397) * php 7.4: role apt * php 7.4: role opcache_dashboard * php 7.4: role php * php 7.4: role phpmyadmin * php 7.4: role phppgadmin * php 7.4: role phpredisadmin * php 7.4: role skeleton * php 7.4: forgot php fpm_pools configs Co-authored-by: Lod <46480794+greedybro@users.noreply.github.com> * Missing new "request_terminate_timeout_track_finished" 7.4 fpm option * Fix blackfire agent & client config templates * Fix changelog Co-authored-by: Hugo Alliaume <kocal@live.fr> Co-authored-by: nervo <nervo@nervo.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've followed what's I've done before in #232.
Travis failures: