Build preview images from preview/* branches
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From time to time we need to build images with a feature preview to test in an staging environment. This PR allows us to push a branch named `preview/some-description` in order to build and push an image with the `some-description` tag. It's up to the user to check for name colisions - ie, if they push a `preview/latest` branch.
|
CC: @anaPerezGhiglia |
|
@waj do you think it's worth merging this? |
|
@matiasgarciaisaia can you add some docs to the README? an entry to the table describing the expected behaviour would be fine |
|
I didn't recall there was a README.md 😛 It doesn't belong to this PR, but I've also added some docs for the Github Actions support we added in #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time we need to build images with a feature preview to test in an staging environment. This PR allows us to push a branch named
preview/some-descriptionin order to build and push an image with thesome-descriptiontag.It's up to the user to check for name colisions - ie, if they push a
preview/latestbranch.