Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run build in test/ci branches #2

Open
ggiraldez opened this issue Feb 21, 2019 · 2 comments
Open

Run build in test/ci branches #2

ggiraldez opened this issue Feb 21, 2019 · 2 comments

Comments

@ggiraldez
Copy link
Member

The script refuses to build unless it's being run from a specific version tag or the master or release/xx branches, because it can't define the DOCKER_TAG variable. It would be useful to be able to run the script on test branches. For example, it's common practice to create a ci/fix branch to fix CI related issues. The built Docker tag could be a throw-away or some generic one. The purpose of the build is to check that everything works end-to-end.

@matiasgarciaisaia
Copy link
Member

@ggiraldez I think it's not the same thing, but please check if #8 helps somehow.

If not, can you clarify a bit the desired behaviour?

@ggiraldez
Copy link
Member Author

I can think of two use cases:

  • testing that the Docker image builds, but not necessarily pushing the image to the registry; IIRC this was the original intent of the issue
  • building a "preview" image to e.g. test a feature in Rancher staging, nicely addressed by your PR

ysbaddaden added a commit to ysbaddaden/ci-docker-builder that referenced this issue Mar 31, 2022
ysbaddaden added a commit to ysbaddaden/ci-docker-builder that referenced this issue Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants