Handle additional DNF transaction callback actions in DNF 3 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://bugzilla.redhat.com/show_bug.cgi?id=1624652 and https://bugzilla.redhat.com/show_bug.cgi?id=1630113 . It seems that a change in DNF 3 causes transaction callbacks to use actions that aren't included in the callback API definition or docs. Because dnfdaemon/dnfdragora currently kinda assume they know all *possible* callback actions, this winds up causing dnfdragora to crash if it tries to handle a callback with one of these unknown actions. This commit adds the extra actions to the const <-> string dict in dnfdaemon's TransactionProgress callback, so that in the dbus RPMProgress message it sends out, the action will be a string, as dnfdragora's handler for the message expects. A companion commit for dnfdragora will add handling for the new string values, and also make it not crash if an unexpected action shows up. Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
dnfdragora PR: manatools/dnfdragora#116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugzilla.redhat.com/show_bug.cgi?id=1624652 and
https://bugzilla.redhat.com/show_bug.cgi?id=1630113 . It seems
that a change in DNF 3 causes transaction callbacks to use
actions that aren't included in the callback API definition or
docs. Because dnfdaemon/dnfdragora currently kinda assume they
know all possible callback actions, this winds up causing
dnfdragora to crash if it tries to handle a callback with one
of these unknown actions.
This commit adds the extra actions to the const <-> string dict
in dnfdaemon's TransactionProgress callback, so that in the dbus
RPMProgress message it sends out, the action will be a string,
as dnfdragora's handler for the message expects. A companion
commit for dnfdragora will add handling for the new string
values, and also make it not crash if an unexpected action shows
up.
Signed-off-by: Adam Williamson awilliam@redhat.com