Skip to content

Commit

Permalink
fix(react): preserve the target set in tsconfig.lib.json
Browse files Browse the repository at this point in the history
ISSUES CLOSED: nrwl#3601
  • Loading branch information
mandarini committed Sep 8, 2020
1 parent 0949ed0 commit 87ffcc0
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 10 deletions.
22 changes: 13 additions & 9 deletions e2e/react/src/react-package.test.ts
Expand Up @@ -107,22 +107,26 @@ forEachCli('nx', (cli) => {

/**
*
* Here I would update my library file
*
* updateFile(`libs/${myLib}/src/lib/${myLib}.tsx`, (content) => {
*
* Not sure how, will find how.
*
* })
*
* I would just add this in the end:
* Here I update my library file
* I am just adding this in the end:
*
* export const TestFunction = async () => {
* return await Promise.resolve('Done!')
* }
*
* So that I can see the change in the Promise.
*
*/

updateFile(`libs/${myLib}/src/lib/${myLib}.tsx`, (content) => {
return `
${content} \n
export const TestFunction = async () => {
return await Promise.resolve('Done!')
}
`;
});

updateFile(`libs/${myLib}/tsconfig.json`, (content) => {
const json = JSON.parse(content);

Expand Down
2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "@nrwl/nx-source",
"version": "999.8.3",
"version": "10.1.0",
"description": "Extensible Dev Tools for Monorepos",
"homepage": "https://nx.dev",
"main": "index.js",
Expand Down

0 comments on commit 87ffcc0

Please sign in to comment.