New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web package builder overrides target of tsconfig.lib.json #3601
Labels
Comments
scdc
changed the title
Web package builder override target of tsconfig.lib.json
Web package builder overrides target of tsconfig.lib.json
Aug 26, 2020
mandarini
added a commit
to mandarini/nx
that referenced
this issue
Sep 4, 2020
Merged
Merged
mandarini
added a commit
to mandarini/nx
that referenced
this issue
Sep 8, 2020
mandarini
added a commit
to mandarini/nx
that referenced
this issue
Sep 8, 2020
jaysoo
pushed a commit
that referenced
this issue
Sep 14, 2020
* feat(react): wip: initial e2e test by jack and web package builder fix Updated some commnets about versions of Storybook, extra config files, and how to treat these * fix(web): preserve the target set in tsconfig.lib.json ISSUES CLOSED: #3601 * fix(react): preserve the target set in tsconfig.lib.json ISSUES CLOSED: #3601 * fix(react): preserve the target set in tsconfig.lib.json ISSUES CLOSED: #3601
vivekmore
pushed a commit
to vivekmore/nx
that referenced
this issue
Sep 19, 2020
* feat(react): wip: initial e2e test by jack and web package builder fix Updated some commnets about versions of Storybook, extra config files, and how to treat these * fix(web): preserve the target set in tsconfig.lib.json ISSUES CLOSED: nrwl#3601 * fix(react): preserve the target set in tsconfig.lib.json ISSUES CLOSED: nrwl#3601 * fix(react): preserve the target set in tsconfig.lib.json ISSUES CLOSED: nrwl#3601
Doginal
pushed a commit
to Doginal/nx
that referenced
this issue
Nov 25, 2020
* feat(react): wip: initial e2e test by jack and web package builder fix Updated some commnets about versions of Storybook, extra config files, and how to treat these * fix(web): preserve the target set in tsconfig.lib.json ISSUES CLOSED: nrwl#3601 * fix(react): preserve the target set in tsconfig.lib.json ISSUES CLOSED: nrwl#3601 * fix(react): preserve the target set in tsconfig.lib.json ISSUES CLOSED: nrwl#3601
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
When building umd module with web package builder, the typescript target config of the library is overriden with 'es5'
Expected Behavior
Nx Package bundler should use target from the tsconfig.lib.json of the library.
It's a regression from Nx 8 where the correct target was used.
Steps to Reproduce
The problem is located in
https://github.com/nrwl/nx/blob/master/packages/web/src/builders/package/package.impl.ts
The target configuration is overridden when configuring the rollup typescript plugin
The text was updated successfully, but these errors were encountered: