Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better extract overlapping strings #1271

Closed
williballenthin opened this issue Jan 9, 2023 · 1 comment · Fixed by #1273
Closed

better extract overlapping strings #1271

williballenthin opened this issue Jan 9, 2023 · 1 comment · Fixed by #1273
Labels
blocked-on-viv blocked on a vivisect bug/release bug Something isn't working viv-bug

Comments

@williballenthin
Copy link
Collaborator

williballenthin commented Jan 9, 2023 •
edited
Loading

when a substring is referenced from a larger string, we extract the wrong amount of data. this seems to be a viv bug having to do with overlapping locations.
@williballenthin williballenthin mentioned this issue Jan 9, 2023
Merged
3 tasks
@williballenthin
Copy link
Collaborator Author

reported upstream
vivisect/vivisect#562

@williballenthin williballenthin added bug Something isn't working blocked-on-viv blocked on a vivisect bug/release viv-bug labels Jan 9, 2023
williballenthin added a commit that referenced this issue Jan 9, 2023
@williballenthin
viv: insn: string: handle viv bug around substrings
4e0e540 
closes #1271
@williballenthin williballenthin mentioned this issue Jan 9, 2023
Merged
3 tasks
mr-tz pushed a commit that referenced this issue Jan 11, 2023
@williballenthin @mr-tz
viv: insn: string: handle viv bug around substrings
ffef4a2 
closes #1271
@mr-tz mr-tz closed this as completed in 5513d4c Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked-on-viv blocked on a vivisect bug/release bug Something isn't working viv-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

viv: insn: string: handle viv bug around substrings mandiant/capa
1 participant
@williballenthin