dotnet update: emit enclosing class information for nested classes #1913
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Great work @bkojusner - your code is coming along nicely. Please see my comments and suggestions. Let me know here if you have any questions 🚀
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
There was a problem hiding this comment.
Good work @bkojusner this is coming together nicely. Please address my comments and re-request a review from me when you're ready. Let me know if you have any questions along the way 😃.
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
Uploaded two test samples for the unit tests at mandiant/capa-testfiles#224. |
There was a problem hiding this comment.
@bkojusner nice work! A few small changes for you to address and then we are ready to merge 🚀
| nested_class_table = {} | ||
|
|
||
| # Used to find nested classes in typedef | ||
| for _rid, nestedclass in iter_dotnet_table(pe, dnfile.mdtable.NestedClass.number): |
There was a problem hiding this comment.
Is _rid being used here? If not, see my suggestion above
|
woohoo congrats @bkojusner! |
|
awesome! 🥳 |
Draft PR with progress to resolve #1780