Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow floating point number in timing metrics. Chrome needs them #8

Merged
merged 1 commit into from
May 4, 2020
Merged

Allow floating point number in timing metrics. Chrome needs them #8

merged 1 commit into from
May 4, 2020

Conversation

jackinloadup
Copy link
Contributor

@jackinloadup
Copy link
Contributor Author

I haven't really dug into the fix. I was trying to get it to print out the debug information. Without this patch it wont print. I'm assuming that once it prints it's likely okay...

@mandrean
Copy link
Owner

mandrean commented May 4, 2020

@jackinloadup Thanks for the PR!

Technically the HAR spec uses Number in many places, which is equivalent to f64 in Rust, so this LGTM. ❤️

@mandrean mandrean merged commit 6587f7c into mandrean:master May 4, 2020
mandrean pushed a commit that referenced this pull request May 4, 2020
@jackinloadup @mandrean
BREAKING CHANGE: Allow floating point number in timing metrics (#8)
ab05563
mandrean pushed a commit that referenced this pull request May 4, 2020
@jackinloadup @mandrean
refactor: Allow floating point number in timing metrics (#8)
4773e5e 
BREAKING CHANGE
@mandrean mandrean mentioned this pull request May 4, 2020
Closed
@mandrean
Copy link
Owner

mandrean commented May 4, 2020

I just realized these fixes should be ported to v1.3 as well. Opened an issue for that: #10

mandrean added a commit that referenced this pull request May 4, 2020
@mandrean
Merge pull request #12
64b8276 
Port changes from #8 to v1.3
@mandrean mandrean mentioned this pull request Oct 12, 2020
Merged
mandrean added a commit that referenced this pull request Oct 13, 2020
@mandrean
Merge pull request #14
7d84eb4 
This PR removes the _charlesStatus field that snuck into the codebase, fixing #13.

It also:
• Fixes a regression in the test fixtures introduced by #8
• Some minor maintenance and refactoring, like removing or bumping deps and using a macro to remove some repetitive serde annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid type: floating point
2 participants
@jackinloadup @mandrean