-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Hardware Serial for esp32 #31
fix Hardware Serial for esp32 #31
Conversation
Hi @nguyenhuudamy Thanks for the PR. However I don't like the idea of changing an established API. It would for sure break my projects not to mention anyone who already uses this library... Perhaps we can overload the function or wrap it in a #if #else to fix it just for the esp32 platform while retaining the Arduino compatible API. |
What about something like this? .cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I added the requested #if def
and modified the examples in order to be compatible. It has compiled however I have no way of testing it on any board at the moment. Could anyone with access to an ESP32 board try this? Maybe @ASMotionLab if you have time.
Thanks @mandulaj, looks great at a glance - I will check it out this evening, test with my ESP32 and report 👍 |
I managed to get hold of an ESP32 and it seems to work fine... So I am ready to merge right away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the ESP32 switch and it works fine now
No description provided.