Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page URL can't contain '/' #22

Closed
PunkChameleon opened this issue Aug 23, 2013 · 5 comments
Closed

Page URL can't contain '/' #22

PunkChameleon opened this issue Aug 23, 2013 · 5 comments
Labels

Comments

@PunkChameleon
Copy link
Member

As of now, if you create a page with '/' in it, then it wont be able to be displayed.

This is because of how the routes and databases are aligned (line 64 of index.js) -- sub directories are recognized because it gets confused.

I'm unsure as to whether to proceed with blocking these characters or enabling them -- later, with nested navigation, we will probably have to build a grander scheme for allowing nested navigations.

For now, let's just disabled the entering of '/' in page routes.

PunkChameleon added a commit that referenced this issue Dec 16, 2013
@SotiriosVrachas
Copy link
Member

is this still a bug?

@PunkChameleon
Copy link
Member Author

Just tested:

I think the fix escapes the '/' but when you actually try and make a page with a '/' in the url and visit it in a running instance, it doesn't work and defaults to 'index.html'. Also, when you go to edit the page, you see the '%20' in the url name. Maybe we can just do validation on the client-side to not allow this?

@SotiriosVrachas
Copy link
Member

validation should be done on both sides for everything that needs validation, client side validation is just less server traffic.

@PunkChameleon
Copy link
Member Author

agreed

@PunkChameleon
Copy link
Member Author

Added client-side validation with server-side as @SotiriosVrachas suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants