Upgrade to AniList's API v2 #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 75.11% 71.15% -3.97%
==========================================
Files 80 80
Lines 4987 4933 -54
==========================================
- Hits 3746 3510 -236
- Misses 1241 1423 +182
Continue to review full report at Codecov.
|
|
🔥 🔥 |
RaitoBezarius
approved these changes
Jan 20, 2018
mangaki/mangaki/wrappers/anilist.py
Outdated
| raise AniListException(data['error']) | ||
| if data.get('errors'): | ||
| for error in data['errors']: | ||
| raise AniListException(error) |
There was a problem hiding this comment.
That means that only one error is raised. Others are silenced.
Maybe let's put an array of errors. It's up to you.
mangaki/mangaki/wrappers/anilist.py
Outdated
| data = self._request( | ||
| '{worktype}/{id}/page', | ||
| {'worktype': worktype.value, 'id': id} | ||
| query=read_graphql_query('work-info'), |
There was a problem hiding this comment.
We could make 'work-info' as a constant static string in the head of this file, so that we can easily change all occurrences of it.
mangaki/mangaki/wrappers/anilist.py
Outdated
| data = self._request( | ||
| '{worktype}/search/{title}', | ||
| {'worktype': worktype.value, 'title': title} | ||
| query=read_graphql_query('user-list'), |
There was a problem hiding this comment.
Same remark for 'user-list' as 'work-info'.
mangaki/mangaki/wrappers/anilist.py
Outdated
| variables.update({'season': (season or to_anime_season(datetime.now())).name}) | ||
| variables.update({'seasonYear': year or datetime.now().year}) | ||
| variables.update({'status': AniListStatus.RELEASING.name} if only_airing else {}) | ||
| variables.update({'perPage': 50}) |
There was a problem hiding this comment.
Let's make it a default parameter per_page of this method.
| raise RuntimeError('Malformed JSON, or AniList changed their API.') | ||
|
|
||
| if data['Page']['pageInfo']['hasNextPage'] and current_page < data['Page']['pageInfo']['lastPage']: | ||
| yield from self.list_seasonal_animes(year=year, season=season, only_airing=only_airing, current_page=current_page+1) |
mangaki/mangaki/wrappers/anilist.py
Outdated
| variables = {} | ||
| variables.update({'username': username}) | ||
| variables.update({'mediaType': worktype.name}) | ||
| variables.update({'perPage': 50}) |
There was a problem hiding this comment.
Let's make it a default parameter.
| hibike_entry = self.anilist.get_work_by_id(AniListWorks.animes, 20912) | ||
| hibike = insert_work_into_database_from_anilist(hibike_entry) | ||
| hibike_entry = self.anilist.get_work(search_id=20912) | ||
| # FIXME: properly mock the insertion of related works |
There was a problem hiding this comment.
Do we really have to mock them? Can we not add them directly? And let them aside?
salixor
force-pushed
the
mrsalixor/anilist-api-v2
branch
from
4b99422
to
0b93dc4
Compare
jilljenn
added a commit
that referenced
this pull request
May 24, 2018
* Search for alternative titles and title when searching a work (#530) * Add CFM: convex factorization machine (#512) * Add factorization machine * Add fastFM to requirements * Add Cython dependency * Add comment, remove some logs and upgrade pip * Add python-dev and libopenblas-dev to requirements (yes yes) * I should sleep * Fix minor changes * Add auto-fix, re-open, close buttons to Mangaki Fix (#527) * Add auto-fix, re-open, close buttons to Mangaki Fix * Fallback gracefully in case of external modifications of the state * Mark MAL as source of truth for further MAL imports (#532) * Add forgotten dep on fastFM in setup.py (#537) * Removing duplicates using dedupe (#463) * Adding management command to train dedupe * Removing debugging and changing saving directory * Output file now supported to retrieve clusters and scores * adding dedupe to dev.txt, changing handler and argument sparser * adding dedupe requirement in the right file, making some changes to dedupe.py * Add DATA_DIR * Up numpy * Fix Ansible config (LOL) (#541) * Fix stupid syntax error * Update README * Rewrite user profile settings (legacy routes killed, replaced by Vue.js + API) (#531) Introduce Vue.js on settings. Kill some legacy routes. Have fun with ugly views. * Test recommendation endpoint and saving of snapshots (#539) * Test recommendation endpoint and saving of snapshots * Fix annoying module problem * Fix test * Decode UTF-8 HTTP response * Test DPP (#538) * Test DPP * Actually test DPP * Upgrade to AniList's API v2 (#535) * Handle AniList's API v2 * Suppress the now useless AniListRichEntry * Get a work by ID or title in the same method * Properly handle seasonal animes from AniList * Update tests for the new version of the API * Shortcuts on Mangaki (#389) * Initial shortcuts ; proof of concept * Plug into onchange event rather than rolling out our own custom event * Add keyboard shortcut settings and cheatsheet * Add migration for new profile setting * Add new recommendation algorithm FMA (#549) * Add new recommendation algorithm FMA * Nit * Add comments * Fix hypothesis version and fix error due to upgrade (#558) * Delete SearchIssue model * Delete Neighbour model * Delete Event/Attendee/Location models * Actually delete events * 🔫 Google Analytics * Add new ALS (#544) * Add new ALS * Change nature of data * Speed up ALS3 * Add references to algorithms * GDPR compliancy — Step 1 (Export features) (#553) Export features for users. * Unreviewed: Fix setupfile → sendfile typo in setup.py * Add X-SendFile for NGINX on Ansible playbooks (#563) * GDPR compliancy — Step 3 (frontend and account deletion) (#564) * MAL duplication problem test (#565) * Improve MAL accuracy (#533) * WIP: GDPR compliancy — Step 4 (frontend polish & copy changes) (#566) * Frontend factor: split profile into profile-works and profile-preferences * Fix anonymous profile view * Prevent Flash of Uncompiled Content with the modal * Opt-in for newsletter and research by design * Explain use of personal data on signup page (#560) * Add explanation on signup page * Remove toggle from FAQ * Fix migrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to the new version of the API, built on GraphQL 🚀
And it also removes the process of authentication required by the first version of the API.
Wrapper
.graphqlfiles)management/commands/anilist_tags_to_json.pyaccordingly (in which some elements of the wrapper are used)Tests
FIXMEin tests where RelatedWorks have to be built : couldn't find a way to properly mock this operation