Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghosts get max hp "restored" incorrectly. #1190

Closed
flambard-took opened this issue Jan 28, 2019 · 1 comment
Closed

Ghosts get max hp "restored" incorrectly. #1190

flambard-took opened this issue Jan 28, 2019 · 1 comment

Comments

@flambard-took
Copy link
Member

Not sure if this is relevant to the stable branch, but I've found

p_ptr->mhp = p_ptr->lev + 2;

in the ghosting routine in 1.2.0.

I might be missing something (like, are ghosts supposed to get that much hp? if so, this is certainly not enforced anywhere else in the code... nor mentioned in any comments... or is it?), so I'm leaving this open.

TODO: examine and comment re: stable branch.

@flambard-took
Copy link
Member Author

After some investigating, this looks to be intended behavior, but bugged.

This should be enforced differently: ghosts should get all their bonuses/stats recalculated as in level up/memory loss, and that piece of code should go there, overriding character/class hit-dice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant