Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor correction: Datadog #4

Merged
merged 1 commit into from
Nov 1, 2016
Merged

minor correction: Datadog #4

merged 1 commit into from
Nov 1, 2016

Conversation

irabinovitch
Copy link
Contributor

s/DataDog/Datadog/

s/DataDog/Datadog/
@jantman
Copy link
Contributor

jantman commented Nov 1, 2016

@irabinovitch I see that your account activity for the past few days seems to be filled with mostly changes to capitalization and minor typo corrections, in Datadog-related repositories.

The following is my personal opinion/response as a contributor to this repo, not as a Manheim employee; I don't know how the other maintainers feel about this:

Would you kindly provide some explanation for this PR? To be honest, I'm having trouble trying to determine if your GitHub account is an actual human who is associated with Datadog (or just annoyed by the common incorrect capitalization of their name, which is certainly a valid complaint), or a PR-opening-bot, or... one of those people who claim to be "prolific open source contributors" by making an endless stream of spelling and grammar corrections.

My gut reaction is to approach this how I've dealt with similar PRs on personal repos, trying to balance being open and welcoming to all contributors while discouraging behavior that appears as though it might, possibly be harmful to the community:

If you can take the time to write a few sentences explaining why you're opening this PR, how you found this repo (other than searching all of GitHub for "DataDog"), and why it seems like you're s/DataDog/Datadog/-ing all of GitHub, and perhaps acknowledge that we can't/won't merge this because the unit tests are failing... then I'll be happy to merge it. Otherwise, I'll assume that one of the above situations is true, and close this PR.

@jantman
Copy link
Contributor

jantman commented Nov 1, 2016

Someone just pointed me to your LinkedIn...

@jantman jantman merged commit de8aa8b into manheim:master Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants