ConditionalApplyPlugin - allow apply on specific branches

[kmanning]

• Allow the branch (master) to be customized
• (REMOVING disable - See Issue ConditionalApplyPlugin - disable to allow apply on any branch, not just master #329 )

[kemper]

For allowing this plugin to be disabled, I take that to mean always apply? I can update my changes to support that. One option is to take an empty list of branches to mean "all"

ConditionalApplyPlugin.withBranchApplyEnabledFor([])

or an extra option:

ConditionalApplyPlugin.withBranchApplyEnabledFor([], all: true)

or a wildcard:

ConditionalApplyPlugin.withBranchApplyEnabledFor(['*'])

or I can add a new method and new field for controlling enable/disable.

ConditionalApplyPlugin.setEnabled(false)

[kmanning]

Let's split this issue into 2 - they are distinct. I updated the original post, and lets use this issue just for changing the branch from master to something else.

[kmanning]

Issues #25 and #172 are related. I wonder if the code examples should be changed to reflect the relationship. Consider the following:

Issue #25 - allow apply on specific branches

ConditionalApplyPlugin.withApplyOnBranch('master')
// or alternatively
ConditionalApplyPlugin.withApplyOnBranch('master', 'test-branch')

Issue #172 - allow apply on specific branches

ConditionalApplyPlugin.withApplyOnEnvironment('qa')
// or alternatively
ConditionalApplyPlugin.withApplyOnEnvironment('qa', 'test-env')

[kemper]

Sounds good to me. Current the name/parameter combination on the PR is withBranchApplyEnabledFor(['branch1', 'branch2') . Do you want me to rename and change the params to be varargs?

[kmanning]

Yes on the rename.

On the varargs, it feels friendlier. So yes, I'd personally appreciate it, unless there's a good reason not to.