Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CRQ Plugin #283

Closed
kmanning opened this issue Aug 5, 2020 · 5 comments · Fixed by #402
Closed

Remove CRQ Plugin #283

kmanning opened this issue Aug 5, 2020 · 5 comments · Fixed by #402
Milestone

Comments

@kmanning
Copy link
Collaborator

kmanning commented Aug 5, 2020

  • This plugin is manheim-specific. Remove it from this library, and push it to a separate library.
@kmanning kmanning added this to the v6.0 milestone Aug 5, 2020
@jleopold28
Copy link
Contributor

@kmanning Are will still planning on removing the CRQ plugin?

@kmanning
Copy link
Collaborator Author

kmanning commented Apr 26, 2021

Yes. If it needs to stick around, there's a separate internal project that it can live in, and be pulled in as a separate library. I tentatively marked it for v6.0 release, in case it would be a breaking change.

@jantman
Copy link
Contributor

jantman commented Aug 11, 2021

@kmanning This plugin leverages an internal Manheim tool (manheim_remedy) that's deprecated. We're getting increasing internal pressure from the teams that manage the backend systems that tool connects to, to deprecate it ASAP. We have an internal replacement for it, the jenkins-crq library.

What's needed from me/us to get some more momentum behind this issue?

@kmanning
Copy link
Collaborator Author

PR's are welcome. I don't think this should be originally been added to the library, and the replacement using the jenkins-crq library is already available in an internally.

I think a PR to simply remove this plugin all together would be appropriate.

@kmanning kmanning modified the milestones: v6.0, v5.18 Aug 11, 2021
@kmanning
Copy link
Collaborator Author

Pushing this to v5.18. The replacement plugin is available in an internal library (or can be added directly in any pipeline)

kmanning added a commit that referenced this issue Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants