Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithAwsPlugin - Add configurable duration (or other options) for longer sessions #444

Closed
jantman opened this issue Nov 1, 2022 · 0 comments · Fixed by #445
Closed

WithAwsPlugin - Add configurable duration (or other options) for longer sessions #444

jantman opened this issue Nov 1, 2022 · 0 comments · Fixed by #445
Milestone

Comments

@jantman
Copy link
Contributor

jantman commented Nov 1, 2022

The WithAwsPlugin currently only supports specifying the role (ARN) parameter for the underlying withAws pipeline step.

This results in credentials that are only valid for 1 hour, and problematic issues with long-running operations like creating RDS read instances... at worst, if using S3 remote state, a single operation that takes longer than an hour results in the credentials expiring and not being able to update the state file. This means the state file is out of sync, and may result in orphaned resources.

The simple fix here would be to allow withRole to take an optional integer duration parameter which is passed on to withAws(). Even better would be to allow withRole to accept any additional parameters (e.g. externalId, roleSessionName, etc.) that withAws() accepts, and pass them through to the underlying withAws() call.

(Opening this issue for a colleague, I didn't experience it myself.)

jantman added a commit to jantman/terraform-pipeline that referenced this issue Nov 1, 2022
jantman added a commit to jantman/terraform-pipeline that referenced this issue Jan 4, 2023
vincentclee added a commit that referenced this issue Mar 10, 2023
Fixes #444 - Add duration parameter to WithAwsPlugin.withRole()
@vincentclee vincentclee added this to the v5.20.0 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants