Fixes #444 - Add duration parameter to WithAwsPlugin.withRole()

[jantman]

Work in progress PR to fix #444 by adding an optional duration parameter to WithAwsPlugin.withRole().

Merge Checklist

• Have you linked this Pull Request to an Issue?
• Have you updated any relevant README files, to explain how this new feature works (with examples)?
• Have you added relevant test cases for your change?
• Do all tests and code style checks pass with ./gradlew check --info?
• Have you successfully run your change in a pipeline in a Jenkins instance?
• Have you updated the CHANGELOG?

[codecov-commenter]

Codecov Report

Base: 82.52% // Head: 82.35% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (d4550dd) compared to base (48af506).
Patch coverage: 55.55% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   82.52%   82.35%   -0.18%     
==========================================
  Files          54       54              
  Lines        1511     1519       +8     
  Branches      322      323       +1     
==========================================
+ Hits         1247     1251       +4     
- Misses        115      117       +2     
- Partials      149      151       +2     

Impacted Files	Coverage Δ
src/WithAwsPlugin.groovy	54.83% <55.55%> (-1.69%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bgshacklett]

This is working in at least one pipeline, now!

[kmanning]

This fix looks good overall, but one minor tweak.

This feature is an example of trying to configure a plugin that has multiple different parameters, which can be set independently of one another.

Rather than trying to overload the .withRole() method to optionally accept a role/role+duration/duration, can we simply add a .withDuration() method? That way, if you want to set duration, you can do so explicitly. If you want to set the role, you can do so explicitly. If you want to set them both, then you chain and call them both explicitly.

By using the suggestion above, we can avoid the awkardness and lack-of-context in your example above: WithAwsPlugin.withRole(null, 43200). "What is 43200? What does that have to do with a null role?" vs WithAwsPlugin.withDuration(43200) which gives context to 43200. "43200 is a duration".

This is a convention that's used heavily across all the plugins, so I'd like to keep that consistent. https://en.wikipedia.org/wiki/Fluent_interface

[jantman]

Rebased on master, and finally getting around to making the changes requested in the previous comment.

[jantman]

@kmanning I've (finally) updated this PR as per the discussion above. Note that while the unit tests pass, I have not tested this in an actual pipeline yet, as I don't have one appropriate for that.

@bgshacklett Is there any chance that, when you have time, you could update your pipeline with these changes?

[kmanning]

[vincentclee]

I am continuing where @bgshacklett left off. This change has been tested internally and is ready to be merged and a release cut. Thank You.