-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 368: Prompt the user *again* if a pending migration is detected. Optionally disable. #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kmanning
commented
Apr 20, 2021
- Issue FlywayPlugin: Prompt the user *again* before applying migration #368
- Applying a migration may be an uncommon case - more commonly, no pending migration may exist
- Because this is an uncommon occurrence, a user may not be accustomed to validating during the "plan" stage whether or not a pending migration exists.
- As an extra safe guard, optionally prompt the user again if a migration is detected - reconfirm that the user is aware that a pending migration exists, and approves the application of said migration.
- This should be optional
Suggested implementation:
|
kmanning
force-pushed
the
issue_368
branch
6 times, most recently
from
April 23, 2021 19:21
86c1e07
to
4c03a21
Compare
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 80.53% 80.81% +0.27%
==========================================
Files 51 51
Lines 1408 1428 +20
Branches 311 314 +3
==========================================
+ Hits 1134 1154 +20
Misses 122 122
Partials 152 152
Continue to review full report at Codecov.
|
kmanning
force-pushed
the
issue_368
branch
2 times, most recently
from
April 23, 2021 19:29
2418022
to
e25c3c1
Compare
kmanning
force-pushed
the
issue_368
branch
6 times, most recently
from
April 26, 2021 17:23
b5e2782
to
2e6f1ee
Compare
kmanning
changed the title
Issue 368: Optionally prompt the user *again* if a pending migration is detected
Issue 368: Prompt the user *again* if a pending migration is detected. Optionally disable.
Apr 26, 2021
kmanning
force-pushed
the
issue_368
branch
2 times, most recently
from
April 26, 2021 19:10
a319fa1
to
57c2154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.