Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential infinite recursion in TerraformImportCommand #440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duckpuppy
Copy link
Contributor

Fixes #439

Merge Checklist

  • Have you linked this Pull Request to an Issue?
  • Have you updated any relevant README files, to explain how this new feature works (with examples)?
  • Have you added relevant test cases for your change?
  • Do all tests and code style checks pass with ./gradlew check --info?
  • Have you successfully run your change in a pipeline in a Jenkins instance?
  • Have you updated the CHANGELOG?

@codecov-commenter
Copy link

Codecov Report

Merging #440 (42eed27) into master (20765fb) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files          54       54           
  Lines        1508     1508           
  Branches      321      321           
=======================================
  Hits         1244     1244           
  Misses        115      115           
  Partials      149      149           
Impacted Files Coverage Δ
src/TerraformImportCommand.groovy 85.29% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20765fb...42eed27. Read the comment docs.

@kmanning
Copy link
Collaborator

kmanning commented Jul 12, 2022

There's documentation for this feature - https://github.com/manheim/terraform-pipeline/blob/master/docs/TerraformImportPlugin.md

  1. Is the documentation correct?
  2. Does the example from the documentation reproduce the error?
  3. Were you able to reproduce the error? (Ie: do we know that this will fix the problem)
  4. Can we add the documentation to the landing README, if this is a feature that is "ready"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TerraformImportCommand may enter an infinite loop
3 participants