Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PIM AAD Policies and Rules #256

Closed
wants to merge 6 commits into from

Conversation

oWretch
Copy link
Contributor

@oWretch oWretch commented Aug 11, 2023

Apply for both AAD and Group PIM roles. Final PR to complete #248.

Apply for both AAD and Group PIM roles
@oWretch
Copy link
Contributor Author

oWretch commented Feb 25, 2024

A service principal can now activate the PIM groups. I've updated the tests to create the group, and they run successfully under the SP. It just needs to have the following Graph permissions:

  • RoleManagement.ReadWrite.Directory
  • RoleManagementPolicy.ReadWrite.AzureADGroup
  • RoleManagementPolicy.ReadWrite.Directory

Test passes happily 🙂

=== RUN   TestRoleManagementPolicyClient
--- PASS: TestRoleManagementPolicyClient (24.86s)
PASS
ok  	github.com/manicminer/hamilton/msgraph	25.657s

@oWretch oWretch marked this pull request as draft February 29, 2024 05:06
MSGraph calls it a subjectSet, and it can have different
ID names depending on the type of object assigned.
ID was working on create but failing on read
@oWretch
Copy link
Contributor Author

oWretch commented Mar 6, 2024

Replaced by #277

@oWretch oWretch closed this Mar 6, 2024
@oWretch oWretch deleted the f/pim-rolemgmt-policy branch March 6, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant