Add support for PIM Group management #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had been in one client to try and automate the PIM activation which didn’t work.
Had been in one client to try and automate the PIM activation which didn’t work.
Apply for both AAD and Group PIM roles
Now that a Service Principal can do this :D
Now that a Service Principal can do this :D
Now that a Service Principal can do this :D
MSGraph calls it a subjectSet, and it can have different ID names depending on the type of object assigned. ID was working on create but failing on read
This was referenced Mar 6, 2024
|
Test runs |
manicminer
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Thank you for working on this heavyweight feature @oWretch! This is a great implementation and looks good to merge. The relevant tests are all passing in the M365 testing tenant.
Thanks also to @iwarapter for the collaboration and testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of #253, #254, #256, #276 into a single PR for review.