Support for attributeSets
#273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Hi @tiwood, thanks for submitting this PR! Given that attributeSets are immortal and have a quota of 500 per tenant, could you update the test to use a predictable name? When the test runs, it could create the attributeSet only if it's not present, and then proceed to update it afterwards. WDYT?
manicminer
added
enhancement
|
Hi @tiwood, just checking in to see if you're able to continue work on this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for attributeSets
Warning! attributeSets cannot be DELETED or RENAMED, they are permanent. (see here)
Related:
hashicorp/terraform-provider-azuread#913