Config: add WithUserAgent config option. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbowes I'm not sure how we want to approach the Version updates? Usually, when we have a tool that needs to be built - like our CLIs - we update it on build time. Seeing that this package should be vendored, we can't do that. I was thinking of a make target, Thoughts? |
This adds the option to add a custom UserAgent to the client as well as initializing a default UserAgent. This allows people to use tracking to see how much the specific client is hitting their API. The UserAgent will be in the format of `go-manifold-$version ($custom)`.
jelmersnoeck
force-pushed
the
jelmer-user-agent
branch
from
7d51d93
to
27a2d82
Compare
👍 |
|
This looks great! My only nitpick is to make sure to include a |
jbowes
approved these changes
Oct 30, 2017
|
approved. feel free to to the makefile target here or in another pr. |
|
I'll add it in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to add a custom UserAgent to the client as well as
initializing a default UserAgent. This allows people to use tracking to see
how much the specific client is hitting their API.
The UserAgent will be in the format of
go-manifold-$version ($custom).