Add event for internal user modification #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sslotsky
reviewed
Jan 7, 2019
|
|
||
| // AccountUpdatedData holds the event specific data | ||
| type AccountUpdatedData struct { | ||
| Reason string `json:"reason"` |
There was a problem hiding this comment.
Does json:"reason" mean that when this struct is serialized to JSON, the key will be named reason?
sslotsky
reviewed
Jan 7, 2019
| // AccountUpdatedData holds the event specific data | ||
| type AccountUpdatedData struct { | ||
| Reason string `json:"reason"` | ||
| OldName *string `json:"old_name,omitempty"` |
There was a problem hiding this comment.
Interesting. How many entries does this comma delimited list accept? Do they need to be ordered in a certain way?
There was a problem hiding this comment.
Yeah, it's usually json:"KEY,OPTIONS" where KEY is the encoding key, and OPTIONS are options for encoding (e.g. something like omitempty to not include it if it isn't set. Some more info if you're interested: https://golang.org/pkg/encoding/json/#Marshal
It's also more powerful than just JSON marshalling: https://github.com/golang/go/wiki/Well-known-struct-tags
sslotsky
approved these changes
Jan 7, 2019
enmand
deleted the
dan/improvements/6798-internal-user-modification-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
AccountUpdatedandAccountUpdatedDatafor internal user modification requests.