The final api unification changes #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keypairs, machines, org_invites, users, and version all had calls that were registry specific along with daemon specific calls. Move the registry ones into the registry package.
Some registry endpoints return encrypted values that are of no use to the cli frontend without first being decrypted by the daemon. Shadow these fields so they can't accidentally be used from the cli frontend.
ianlivingstone
approved these changes
Dec 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the remaining api calls that are registry specific from
apitoregistry.Ensure that any endpoints that return encrypted values and would not be useful from the cli frontend are shadowed in
api, to prevent accidental use.