Add a plan display component that can be used independently #231
Conversation
This component can be used by platforms to display a plan's information if require. This can power resource details page or custom product display pages.
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=========================================
- Coverage 53.54% 53.15% -0.4%
=========================================
Files 32 33 +1
Lines 706 730 +24
Branches 163 164 +1
=========================================
+ Hits 378 388 +10
- Misses 326 340 +14
Partials 2 2
Continue to review full report at Codecov.
|
| /** | ||
| * _(hidden)_ Passed by `<manifold-connection>` | ||
| */ | ||
| 'connection': Connection; |
There was a problem hiding this comment.
I think we’re inconsistent, but this should be marked as optional. Reason is that within TypeScript projects, it’ll throw an error otherwise (connection is internal, so users shouldn’t have to specify that attribute).
Like I said there may still be some spots where that isn’t the case, but just something to note.
There was a problem hiding this comment.
Er—whoops! I meant in manifold-plan.tsx. Not here; this is the auto-generated file.
| planSelector.planChange(newPlan); | ||
| expect(planSelector.fetchProductAndPlan).toHaveBeenCalledWith(productLabel, newPlan); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Nice! In general, we prefer E2E tests—and tests that don’t raise coverage—over spec. Spec is great for certain things, but in general web components being largely HTML are very hard to test & raise coverage in the same way you can with React (there’s no importing; it’s all just HTML).
So all that said, coverage isn’t as big a goal with UI as E2E tests w/ Puppeteer
This component can be used by platforms to display a plan's information if require. This can power resource details page or custom product display pages.