Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noobify welcome demo #699

Merged
merged 11 commits into from
Jul 30, 2022
Merged

noobify welcome demo #699

merged 11 commits into from
Jul 30, 2022

Conversation

ingawei
Copy link
Collaborator

@ingawei ingawei commented Jul 28, 2022

FOR DEMO PURPOSES ONLY, this will show a welcome tutorial everytime, but eventually this will only show for new users.
Screen Shot 2022-07-27 at 8 30 05 PM
Screen Shot 2022-07-27 at 8 33 10 PM
Screen Shot 2022-07-27 at 8 33 27 PM
Screen Shot 2022-07-27 at 8 30 12 PM

@vercel
Copy link

vercel bot commented Jul 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dev ✅ Ready (Inspect) Visit Preview Jul 30, 2022 at 7:42AM (UTC)
docs ✅ Ready (Inspect) Visit Preview Jul 30, 2022 at 7:42AM (UTC)
opengraph-image ✅ Ready (Inspect) Visit Preview Jul 30, 2022 at 7:42AM (UTC)
prod ✅ Ready (Inspect) Visit Preview Jul 30, 2022 at 7:42AM (UTC)

Copy link
Member

@akrolsmir akrolsmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look awesome - thanks for building this out!

One more note, I'd suggest using https://tinypng.com/ to slim down the image sizes

common/user.ts Outdated Show resolved Hide resolved
web/components/onboarding/welcome.tsx Outdated Show resolved Hide resolved
web/components/onboarding/welcome.tsx Outdated Show resolved Hide resolved
@@ -18,6 +18,15 @@ module.exports = {
backgroundImage: {
'world-trading': "url('/world-trading-background.webp')",
},
colors: {
'greyscale-1': '#FBFBFF',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, what's the rationale behind using greyscale-1 instead of the Tailwind gray colors? (I'm not sure what best practices with color naming are haha)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just think it's more consistent with the color palette Rachael designed, her grays are more purpley and I like that :) I also don't know what the best practices are, but I just wanted to make the names distinct enough from the tailwind colors that they couldn't get confused

web/components/onboarding/welcome.tsx Show resolved Hide resolved
web/components/onboarding/welcome.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants