-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
noobify welcome demo #699
noobify welcome demo #699
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look awesome - thanks for building this out!
One more note, I'd suggest using https://tinypng.com/ to slim down the image sizes
@@ -18,6 +18,15 @@ module.exports = { | |||
backgroundImage: { | |||
'world-trading': "url('/world-trading-background.webp')", | |||
}, | |||
colors: { | |||
'greyscale-1': '#FBFBFF', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, what's the rationale behind using greyscale-1
instead of the Tailwind gray colors? (I'm not sure what best practices with color naming are haha)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just think it's more consistent with the color palette Rachael designed, her grays are more purpley and I like that :) I also don't know what the best practices are, but I just wanted to make the names distinct enough from the tailwind colors that they couldn't get confused
FOR DEMO PURPOSES ONLY, this will show a welcome tutorial everytime, but eventually this will only show for new users.