benchmarks on CI #293
Closed
benchmarks on CI #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the benchmark actions are running but failing. Can they be fixed in this PR before merging? |
|
Sorry - should have waited to click that "Review" button :D Many more things need to be added before this PR is ready for a review. |
|
Here is a nice CI workflow that summarises the benchmark through a comment on the open PR: sympy/benchmark-summariser Example comment in use sympy-pr-#23746 |
|
Will restart this PR once I have finished it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to setup the benchmarks in the CI. We will need actual python code to run the benchmarks.
We might have to merge this PR into master before we can see whether the benchmarks are doing anything