BUG FIX: Fix test_bounce_animation #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I ran my initial tox the `test_bounce_animation` test was failing for me because it seemed to assume that my console would be 80 characters wide, which it was not. I used your existing `get_terminal_columns` function to remove the assumption, and now the test should pass regardless of the width of the tester's console. I also fixed a typo.
2 similar comments
This was referenced Oct 14, 2018
Lilja
approved these changes
Oct 15, 2018
manrajgrover
approved these changes
Oct 20, 2018
There was a problem hiding this comment.
@eoinnoble LGTM! 💯 Thanks for looking into it and fixing. I think this was raised recently here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of new feature, or changes
When I ran my initial tox the
test_bounce_animationtest wasfailing for me because it seemed to assume that my console would
be 80 characters wide, which it was not. I used your existing
get_terminal_columnsfunction to remove the assumption, and nowthe test should pass regardless of the width of the tester's
console.
I also fixed a typo.
Checklist
Related Issues and Discussions
This fixes an issue raised in #78.
People to notify
@manrajgrover @otivvormes