Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: Fix test_bounce_animation #99

Merged
merged 1 commit into from
Oct 20, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions tests/test_halo.py
Original file line number Diff line number Diff line change
Expand Up @@ -400,20 +400,22 @@ def test_bounce_animation(self):
def filler_text(n_chars):
return "_" * n_chars

text = "{}abc".format(filler_text(80))
terminal_width = get_terminal_columns()

text = "{}abc".format(filler_text(terminal_width))
expected_frames_without_appended_spinner = [
"{}".format(filler_text(78)),
"{}".format(filler_text(78)),
"{}".format(filler_text(78)),
"{}a".format(filler_text(77)),
"{}ab".format(filler_text(76)),
"{}abc".format(filler_text(75)),
"{}abc".format(filler_text(75)),
"{}ab".format(filler_text(76)),
"{}a".format(filler_text(77)),
"{}".format(filler_text(78)),
"{}".format(filler_text(78)),
"{}".format(filler_text(78)),
"{}".format(filler_text(terminal_width - 2)),
"{}".format(filler_text(terminal_width - 2)),
"{}".format(filler_text(terminal_width - 2)),
"{}a".format(filler_text(terminal_width - 3)),
"{}ab".format(filler_text(terminal_width - 4)),
"{}abc".format(filler_text(terminal_width - 5)),
"{}abc".format(filler_text(terminal_width - 5)),
"{}ab".format(filler_text(terminal_width - 4)),
"{}a".format(filler_text(terminal_width - 3)),
"{}".format(filler_text(terminal_width - 2)),
"{}".format(filler_text(terminal_width - 2)),
"{}".format(filler_text(terminal_width - 2)),
]
# Prepend the actual spinner
expected_frames = [
Expand All @@ -427,8 +429,8 @@ def filler_text(n_chars):
spinner.stop()
output = self._get_test_output()

zippped_expected_and_actual_frame = zip(expected_frames, output)
for multiple_frames in zippped_expected_and_actual_frame:
zipped_expected_and_actual_frame = zip(expected_frames, output)
for multiple_frames in zipped_expected_and_actual_frame:
expected_frame, actual_frame = multiple_frames
self.assertEquals(expected_frame, actual_frame)

Expand Down