Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkspaceFactory outputs invalid workspaces when child contains more spectra than parent #12720

Closed
DanNixon opened this issue Jun 2, 2015 · 3 comments
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@DanNixon
Copy link
Member

DanNixon commented Jun 2, 2015

When creating a child workspace using the WorkspaceFactory where the child will have more spectra than the parent, no modification is done to the vertical axis, hence it ends up being too short for the child workspace which leads to issues if you try and do anything in Mantid the reads the axis.

When this happens the WorkspaceFactory should extend the axis and fill it with either zeros or empty strings to at least make it usable.

@DanNixon
Copy link
Member Author

DanNixon commented Jun 3, 2015

This issue was originally trac ticket 11882

@DanNixon DanNixon added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@DanNixon DanNixon self-assigned this Jun 3, 2015
@DanNixon DanNixon closed this as completed Jun 3, 2015
@rosswhitfield rosswhitfield reopened this Jun 3, 2015
@DanNixon DanNixon added this to the Release 3.5 milestone Jul 31, 2015
@DanNixon DanNixon added the Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) label Jul 31, 2015
@DanNixon DanNixon assigned ElliotAOram and unassigned DanNixon Aug 25, 2015
@NickDraper NickDraper modified the milestones: Release 3.5, Release 3.6 Sep 14, 2015
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
@NickDraper NickDraper modified the milestones: Release 3.7, Release 3.8 May 20, 2016
@NickDraper NickDraper removed this from the Release 3.7 milestone May 20, 2016
@ElliotAOram ElliotAOram removed their assignment Jul 18, 2016
@NickDraper NickDraper modified the milestones: Release 3.8, Release 3.9 Oct 3, 2016
@NickDraper NickDraper modified the milestones: Release 3.9, Temporary Holding Oct 14, 2016
@NickDraper NickDraper removed this from the Temporary Holding milestone Oct 3, 2017
@stale
Copy link

stale bot commented Feb 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 24, 2021
@stale
Copy link

stale bot commented Mar 3, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants