Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WorkspaceFactory outputting workspaces with an invalid vertical axis #834

Closed
wants to merge 5 commits into from

Conversation

DanNixon
Copy link
Member

@DanNixon DanNixon commented Jun 2, 2015

Fixes #12720

I can't think of an easy way to test it other then via code review.

The issue is that differentSize boolean is set false by the create function as it sees that the Y length parameter is the default so it assumes the size does not change.

In the axis code it takes either this boolean flag being false or the axis lengths being identical to assume that the axis length had not changed, which only worked for the X axis.

No release note changes as this is an internal only issue.

This only seems to have been an issue with non spectra axis
@DanNixon DanNixon added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework labels Jun 2, 2015
@DanNixon DanNixon added this to the Release 3.5 milestone Jun 2, 2015
@DanNixon DanNixon changed the title Fix WorkspaceProperty outputting workspaces with an invalid vertical axis Fix WorkspaceFactory outputting workspaces with an invalid vertical axis Jun 2, 2015
@FedeMPouzols FedeMPouzols self-assigned this Jun 9, 2015
@FedeMPouzols
Copy link
Contributor

@DanNixon : The system test CalMuonDeadTimeTest seems not to like this PR. This test is comparing the output of the algorithm CalMuonDeadTime with a file previously saved file. It could well be that the reference file needs an update?

@DanNixon
Copy link
Member Author

@FedeMPouzols I don't think it fails reliably though, I'm sure I have seen a build where is passed (I thought it was the second to last but I can't seem to see that build any more).

I'll have a better look tomorrow.

@FedeMPouzols
Copy link
Contributor

I just tried a rebuid, to see if the maybe? random issue had vanished away after a few days, but it failed again on the same CalMuonDeadTimeTest.

@DanNixon
Copy link
Member Author

Yes, there does seem to be some issue with it.
I have no idea what it is though, when I load the reference file and compare it to the result of me manually running the test they are identical.

@martyngigg
Copy link
Member

Can this be pushed back to 3.7?

@DanNixon DanNixon modified the milestones: Release 3.7, Release 3.6 Feb 1, 2016
@DanNixon DanNixon closed this Feb 23, 2016
@DanNixon DanNixon deleted the 11882_workspacefactory_invalid_vert_axis branch February 23, 2016 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WorkspaceFactory outputs invalid workspaces when child contains more spectra than parent
4 participants