New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WorkspaceFactory outputting workspaces with an invalid vertical axis #834
Conversation
This only seems to have been an issue with non spectra axis
@DanNixon : The system test |
@FedeMPouzols I don't think it fails reliably though, I'm sure I have seen a build where is passed (I thought it was the second to last but I can't seem to see that build any more). I'll have a better look tomorrow. |
I just tried a rebuid, to see if the maybe? random issue had vanished away after a few days, but it failed again on the same |
Yes, there does seem to be some issue with it. |
Can this be pushed back to |
Fixes #12720
I can't think of an easy way to test it other then via code review.
The issue is that
differentSize
boolean is set false by thecreate
function as it sees that the Y length parameter is the default so it assumes the size does not change.In the axis code it takes either this boolean flag being false or the axis lengths being identical to assume that the axis length had not changed, which only worked for the X axis.
No release note changes as this is an internal only issue.