Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InternetHelper incorrectly sets both "Transfer-Encoding: chunked" & "Content-Length" headers #15685

Closed
martyngigg opened this issue Mar 16, 2016 · 0 comments · Fixed by #15687
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework Patch Candidate Urgent issues that must be included in a patch following a release
Milestone

Comments

@martyngigg
Copy link
Member

A HTTP message using any Transfer-Encoding other than identity should not set the Content-Length header - see HTTP protocol. This is currently done in InternetHelper::createRequest.

Servers are supposed to ignore the Content-Length if Transfer-Encoding is specified but at the time this issue was created there was an problem with the proxy servers at RAL mangling the data if both of these header fields were present. This manifests itself by not allowing:

  • uploads to the script repository
  • posting of usage data
    if you are on the RAL network.

To reproduce the problem (only currently reproducible at ISIS):

  • Open your Mantid.user.properties and add
UploaderWebServer=http://upload.mantidproject.org/scriptrepository?debug=1
# Base Url for the remote script repository. Not necessarily accessible, it is used to construct longer URLs
ScriptRepository=http://download.mantidproject.org/dev-scriptrepository/
  • Open MantidPlot, select File->Script Repository and choose an install location
  • Make some change to one of the files (this is a debug repository so no need to worry about user data)
  • Click Reload and then click the Upload button that appears next to the changed file
  • After filling in the required information, click OK and the upload will fail.
@martyngigg martyngigg added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Patch Candidate Urgent issues that must be included in a patch following a release labels Mar 16, 2016
@martyngigg martyngigg self-assigned this Mar 16, 2016
@martyngigg martyngigg added this to the Release 3.7 milestone Mar 16, 2016
@martyngigg martyngigg added the Framework Issues and pull requests related to components in the Framework label Mar 16, 2016
martyngigg added a commit that referenced this issue Mar 16, 2016
Servers should handle the case of both appearing in a header but it
would appear that some are not so graceful...
Refs #15685
martyngigg added a commit that referenced this issue Mar 16, 2016
Servers should handle the case of both appearing in a header but it
would appear that some are not so graceful...
Refs #15685
martyngigg added a commit that referenced this issue Mar 16, 2016
peterfpeterson pushed a commit that referenced this issue Mar 29, 2016
Servers should handle the case of both appearing in a header but it
would appear that some are not so graceful...
Refs #15685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework Patch Candidate Urgent issues that must be included in a patch following a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant