Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U correction makes half of WISH's detectors disappear #18869

Closed
samueljackson92 opened this issue Feb 15, 2017 · 0 comments · Fixed by #18875
Closed

U correction makes half of WISH's detectors disappear #18869

samueljackson92 opened this issue Feb 15, 2017 · 0 comments · Fixed by #18875
Assignees
@samueljackson92
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Patch Candidate Urgent issues that must be included in a patch following a release
Projects
ISIS Powder Diffraction
Milestone
Release 3.10

Comments

@samueljackson92
Copy link
Contributor

samueljackson92 commented Feb 15, 2017 •
edited

Pascal has noted that this is broken. On further investigation it appears it was also broken in 3.8.

Expected behavior

Applying a U correction of min = 0, max = 6.28 should cause the front & backscattering detectors to be flipped.

Actual behavior

Applying a U correction of min = 0, max = 6.28 causes half of WISH's detectors to disappear.

Steps to reproduce the behavior

  • Load WISH file
  • Open instrument view
  • Display settings -> U correction
  • Enter values min = 0, max = 6.28
  • Apply
  • Observe bug

Platforms affected

All
@samueljackson92 samueljackson92 added Component: GUI Patch Candidate Urgent issues that must be included in a patch following a release High Priority An issue or pull request that if not addressed is severe enough to postponse a release. labels Feb 15, 2017
@samueljackson92 samueljackson92 added this to the Release 3.10 milestone Feb 15, 2017
@samueljackson92 samueljackson92 self-assigned this Feb 15, 2017
samueljackson92 added a commit that referenced this issue Feb 15, 2017
@samueljackson92
Refs #18869 Fix U correction view rect
25d21c2
samueljackson92 added a commit that referenced this issue Feb 15, 2017
@samueljackson92
Refs #18869 Fix code formatting
9fff85c 
This code is badly indented. While we're herewe should fix it
@samueljackson92 samueljackson92 mentioned this issue Feb 15, 2017
Merged
9 tasks
samueljackson92 added a commit that referenced this issue Feb 16, 2017
@samueljackson92
Refs #18869 Add release notes.
005202c
samueljackson92 added a commit that referenced this issue Feb 16, 2017
@samueljackson92
Revert "Refs #18869 Fix code formatting"
0deffd9 
This reverts commit 9fff85c.
samueljackson92 added a commit that referenced this issue Feb 21, 2017
@samueljackson92
Refs #18869 Fix blank view with no U correction
9667cea
@samueljackson92 samueljackson92 mentioned this issue Feb 21, 2017
Merged
9 tasks
martyngigg pushed a commit that referenced this issue Feb 23, 2017
@samueljackson92 @martyngigg
Refs #18869 Fix U correction view rect
f14b938 
(cherry picked from commit 25d21c2)

Refs #18869 Fix code formatting

This code is badly indented. While we're herewe should fix it

(cherry picked from commit 9fff85c)

Revert "Refs #18869 Fix code formatting"

This reverts commit 9fff85c.

(cherry picked from commit 0deffd9)

Refs #18869 Fix blank view with no U correction

(cherry picked from commit 9667cea)

Add patch release note
martyngigg pushed a commit that referenced this issue Feb 23, 2017
@samueljackson92 @martyngigg
Cherry pick pull request #18875
2cd3b15 
Refs #18869 Fix U correction view rect

(cherry picked from commit 25d21c2)

Refs #18869 Fix code formatting

This code is badly indented. While we're herewe should fix it

(cherry picked from commit 9fff85c)

Revert "Refs #18869 Fix code formatting"

This reverts commit 9fff85c.

(cherry picked from commit 0deffd9)

Refs #18869 Fix blank view with no U correction

(cherry picked from commit 9667cea)

Add patch release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samueljackson92 samueljackson92

Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Patch Candidate Urgent issues that must be included in a patch following a release
Projects
ISIS Powder Diffraction
Done
Milestone
Release 3.10
Development

Successfully merging a pull request may close this issue.

U correction not correctly applied to viewport mantidproject/mantid
1 participant
@samueljackson92