Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Mantid with Qt5 only #28650

Closed
9 tasks done
AndreiSavici opened this issue May 5, 2020 · 6 comments
Closed
9 tasks done

Build Mantid with Qt5 only #28650

AndreiSavici opened this issue May 5, 2020 · 6 comments
Labels
Framework Issues and pull requests related to components in the Framework GUI Issues and pull requests specific to the Mantid Workbench GUI. Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Milestone

Comments

@AndreiSavici
Copy link
Member

AndreiSavici commented May 5, 2020

This is an umbrella ticket for building on systems where there is no Qt4 (Ubuntu 20.04). It should prepare for the removal of MantidPlot and supporting code but not remove that yet.

The outcome of this is that a build with -DENABLE_MANTIDPLOT=OFF should produce a working package with workbench only.

Edited (mgigg: moved to issue #30268)
~~Nice to haves but not required to be able to disable MantidPlot:

  • [ ] Systemtests pass System tests pass on Ubuntu 20.04 #29362 This is not technically required for Qt5 only but these tests fail on Ubuntu 20.04
  • [ ] Remove code in #if QT_VERSION < QT_VERSION_CHECK(5, 0, 0) directives
  • [ ] Remove Qt4 packages from RPM/DEB dependencies
  • [ ] Remove Qt4 from developer packages

Development docker images will need to have Qt4 installed until we decide to disable MantidPlot on the builds but then they can be removed.

@AndreiSavici
Copy link
Member Author

With changes in #28651, most of the failing tests are because we force Qt4 testing even if it's not available.

@martyngigg
Copy link
Member

@AndreiSavici The system test failures on 20.04, with the exception of PVPython, are not all required to be fixed for us to disable MantidPlot on the other platforms.
Would you be happy if we sorted out disabling MantidPlot first? I'm just aware that Release 6.0 is coming and the code freeze is the start of January so getting this is donesooner is probably better.

@AndreiSavici
Copy link
Member Author

@martyngigg Fine with me. The ORNL team is looking into those tests anyway, but it can be done after removing MantidPlot

@martyngigg
Copy link
Member

Brilliant. Thanks for the update.

@AndreiSavici
Copy link
Member Author

@martyngigg When the PR with removing MantidPlot is merged, we need to send an email to the user community to say that mantidplotnightly is gone.

@martyngigg martyngigg added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Jan 6, 2021
@martyngigg
Copy link
Member

I've moved the remaining parts of this to a new issue that deals with actually removing MantidPlot, #30268, so I'll close this now.

Maintenance automation moved this from Backlog to Done Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework GUI Issues and pull requests specific to the Mantid Workbench GUI. Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Development

No branches or pull requests

3 participants