New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Mantid with Qt5 only #28650
Comments
With changes in #28651, most of the failing tests are because we force Qt4 testing even if it's not available. |
@AndreiSavici The system test failures on 20.04, with the exception of PVPython, are not all required to be fixed for us to disable MantidPlot on the other platforms. |
@martyngigg Fine with me. The ORNL team is looking into those tests anyway, but it can be done after removing MantidPlot |
Brilliant. Thanks for the update. |
@martyngigg When the PR with removing MantidPlot is merged, we need to send an email to the user community to say that mantidplotnightly is gone. |
I've moved the remaining parts of this to a new issue that deals with actually removing MantidPlot, #30268, so I'll close this now. |
This is an umbrella ticket for building on systems where there is no Qt4 (Ubuntu 20.04). It should prepare for the removal of MantidPlot and supporting code but not remove that yet.
-DENABLE_MANTIDPLOT=OFF
Qt4 tests on ubuntu 20.04 #29007 , PR Unit tests ununtu 20 04 #29013QT_API=pyqt4
injected variable in master_systemtests-osx and release_systemtest-osx PR Switch macOS system test runner to use Python from MantidWorkbench bundle #29749QT_API=pyqt5
on rhel7 wrapper script PR Startup scripts now default to pyqt5 #29921The outcome of this is that a build with
-DENABLE_MANTIDPLOT=OFF
should produce a working package with workbench only.Edited (mgigg: moved to issue #30268)
~~Nice to haves but not required to be able to disable MantidPlot:
[ ] Systemtests pass System tests pass on Ubuntu 20.04 #29362 This is not technically required for Qt5 only but these tests fail on Ubuntu 20.04[ ] Remove code in#if QT_VERSION < QT_VERSION_CHECK(5, 0, 0)
directives[ ] Remove Qt4 packages from RPM/DEB dependencies[ ] Remove Qt4 from developer packagesDevelopment docker images will need to have Qt4 installed until we decide to disable MantidPlot on the builds but then they can be removed.The text was updated successfully, but these errors were encountered: