Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Mantid and unit tests #28651

Merged
merged 1 commit into from May 6, 2020
Merged

Build Mantid and unit tests #28651

merged 1 commit into from May 6, 2020

Conversation

AndreiSavici
Copy link
Member

Description of work.

To test:
Make sure that the builds pass. If you have Ubuntu 20.04, try to build on that. For things to work, set QT_API to pyqt5 (export QT_API="pyqt5")

Re #28650

This does not require release notes because is only partial way to transition to workbench only


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@AndreiSavici AndreiSavici mentioned this pull request May 5, 2020
9 tasks
@martyngigg martyngigg self-assigned this May 6, 2020
Copy link
Member

@martyngigg martyngigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all tests now build and the protection for a variable that might be None is sensible.

@gvardany gvardany merged commit 534bab9 into master May 6, 2020
@gvardany gvardany deleted the ubuntu_20_04_build branch May 6, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants