Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load and save diffraction calibration file #12902

Merged
merged 28 commits into from
Jun 24, 2015
Merged

Conversation

peterfpeterson
Copy link
Member

This should allow for loading and saving calibration data for the new AlignDetectors.

This is documented in the release notes here.

@peterfpeterson peterfpeterson added the Diffraction Issues and pull requests related to diffraction label Jun 22, 2015
@peterfpeterson peterfpeterson added this to the Release 3.5 milestone Jun 22, 2015
@peterfpeterson
Copy link
Member Author

The latest windoze build is not finding H5Cpp.h which is in a subdirectory of 3rdpartyincludes. I think it is an issue in either hdf5-targets-windows.cmake or hdf5-config.cmake or CommonSetup.cmake. Of these, I think targets-windows.cmake is the most likely.

@wdzhou wdzhou self-assigned this Jun 23, 2015
@wdzhou
Copy link
Collaborator

wdzhou commented Jun 24, 2015

The new algorithms can save and load offset, mask and group workspaces as designed. The only issue found is that the instrument of the original mask workspace and the one of saved-loaded mask workspace are not same. I point it out though I think it is another issue to mask workspace. Issue is thus closed.

wdzhou added a commit that referenced this pull request Jun 24, 2015
The new algorithms can save and load offset, mask and group workspaces as designed.  The only issue found is that the instrument of the original mask workspace and the one of saved-loaded mask workspace are not same.  I point it out though I think it is another issue to mask workspace.  Issue is thus closed.
@wdzhou wdzhou merged commit 6e498d2 into master Jun 24, 2015
@wdzhou wdzhou deleted the load_and_save_calfile branch June 24, 2015 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants