-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container subtraction tab to indirect #13582
Add container subtraction tab to indirect #13582
Conversation
Code and documentation look good. I have checked that:
I've only noticed an issue when the input workspaces have different binning. In this case, when running the container subtraction, I get the following error: Error in execution of algorithm Minus: @ElliotAOram Not sure how frequent this situation is (sample and container with different binning), so let me know if you would like to solve this in a separate issue and I'll merge this branch. |
Thanks @raquelalvarezbanos I think it's fairly uncommon so it should be fine to solve separately. |
…raction_tab_to_Indirect Add container subtraction tab to indirect
Fixes #13110
The new ContainerSubtraction tab is now in the Indirect Corrections tab.
To Test
Sample
File and matchingContainer
file.This has should now feature in the Indirect_Corrections.rst
ToDo: