Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container subtraction tab to indirect #13582

Merged

Conversation

ElliotAOram
Copy link
Contributor

Fixes #13110

The new ContainerSubtraction tab is now in the Indirect Corrections tab.

To Test

  • Open the ContainerSubtraction tab (Interfaces > Indirect > Corrections > ContainerSubtraction)
  • Select a suitable Sample File and matching Container file.
  • Optionally Scale the container
  • Run the Subtraction
  • Several features need to be checked to ensure that the new tab functions correctly:
    • The plot options plot the correct things
    • The plot preview displays correct and reasonable data
      • This can be checked against the ApplyPaalmanPings tab (without using corrections only can). The can subtraction will be removed from the ApplyPaalmanPings tab at a later date.
    • The relevant files appear in the ADS
      • Original files
      • Wavelength converted versions of the originals (if they were not in wavelength originally)
      • The container subtraction

This has should now feature in the Indirect_Corrections.rst

ToDo:

@ElliotAOram ElliotAOram added the Indirect/Inelastic Issues and pull requests related to indirect or inelastic label Sep 9, 2015
@ElliotAOram ElliotAOram added this to the Release 3.5 milestone Sep 9, 2015
@raquelalvarezbanos raquelalvarezbanos self-assigned this Sep 11, 2015
@raquelalvarezbanos
Copy link
Contributor

Code and documentation look good.

I have checked that:

  • Plot options and Preview plot produce the expected plots
  • Relevant files appear in ADS
  • "Scale Can by factor" works correctly

I've only noticed an issue when the input workspaces have different binning. In this case, when running the container subtraction, I get the following error:

Error in execution of algorithm Minus:
X arrays must match when performing this operation on a 2D workspaces.
Error in execution of algorithm ApplyPaalmanPingsCorrection
X arrays must match when performing this operation on a 2D workspaces.
...

@ElliotAOram Not sure how frequent this situation is (sample and container with different binning), so let me know if you would like to solve this in a separate issue and I'll merge this branch.

@ElliotAOram
Copy link
Contributor Author

Thanks @raquelalvarezbanos I think it's fairly uncommon so it should be fine to solve separately.

raquelalvarezbanos added a commit that referenced this pull request Sep 11, 2015
…raction_tab_to_Indirect

Add container subtraction tab to indirect
@raquelalvarezbanos raquelalvarezbanos merged commit 7ae948f into master Sep 11, 2015
@raquelalvarezbanos raquelalvarezbanos deleted the 13110_Add_container_subtraction_tab_to_Indirect branch September 11, 2015 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants