Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WorkspaceCreation::create(const P &parent) for parent workspaces with varying bins #19247

Merged
merged 13 commits into from
Mar 30, 2017
Merged

Fix WorkspaceCreation::create(const P &parent) for parent workspaces with varying bins #19247

merged 13 commits into from
Mar 30, 2017

Commits on Mar 24, 2017

  1. Copy X data correctly to created workspace when bins vary. 

    Re #19242
    Antti Soininen committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    3f862bb View commit details
    Browse the repository at this point in the history

  2. Update release notes. 

    Re #19242
    Antti Soininen committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    670f6ca View commit details
    Browse the repository at this point in the history

  3. Code beautification. 

    Re #19242
    Antti Soininen committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    7669935 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2017

  1. Remove WorkspaceCreation::create(parent, number) methods. 

    We now explicitly require clients to provide a template histogram.

Re #19242
    Antti Soininen committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    25482cf View commit details
    Browse the repository at this point in the history

  2. Code beautification. 

    Re #19242
    Antti Soininen committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    56a71cb View commit details
    Browse the repository at this point in the history

  3. Remove two create() variants introduced earlier. 

    We now strip y and e data for EventWorkspaces in the original methods.

Re #19242
    Antti Soininen committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    4e46022 View commit details
    Browse the repository at this point in the history

  4. Remove superfluous check. 

    Re #19242
    Antti Soininen committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    53cb35a View commit details
    Browse the repository at this point in the history

  5. Remove special treatment of EventWorkspaces in workspaceCreation. 

    Clients should explicitly use BinEdges when providing histArg.

Re #19242
    Antti Soininen committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    1377938 View commit details
    Browse the repository at this point in the history

  6. Simplify copying of X data from parent workspace. 

    Re #19242
    Antti Soininen committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    0b33521 View commit details
    Browse the repository at this point in the history

  7. Cleanup and beautification. 

    Re #19242
    Antti Soininen committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    9a04bff View commit details
    Browse the repository at this point in the history

  8. Revise release notes. 

    Re #19242
    Antti Soininen committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    f5899eb View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2017

  1. Fix instrument cloning. 

    Re #19242
    Antti Soininen committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    79ba201 View commit details
    Browse the repository at this point in the history

  2. Code beautification. 

    Re #19242
    Antti Soininen committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    0ebfc86 View commit details
    Browse the repository at this point in the history